linux-kernel - Re: [PATCH] sysfs: Remove page boundary align limitation on sysfs_emit and sysfs_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Sep 2021 14:32:06 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Lang Yu <lang.yu@....com>
Cc:     Joe Perches <joe@...ches.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysfs: Remove page boundary align limitation on
 sysfs_emit and sysfs_emit_at

On Wed, Sep 08, 2021 at 08:07:23PM +0800, Lang Yu wrote:
> The key purpose of sysfs_emit and sysfs_emit_at is to
> ensure that no overrun is done. Make them more equivalent
> with scnprintf.

That's not the only purpose.

So why are you changing this?

What in-kernel users are being tripped up by this, shouldn't we fix them
instead?

Remember, sysfs files are "one value per file", so why are the boundries
not properly set here?

thanks,

greg k-h