linux-kernel - Re: [PATCH v16 01/14] counter: stm32-lptimer-cnt: Provide defines for clock polarities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210908183105.062869dd@jic23-huawei>
Date:   Wed, 8 Sep 2021 18:31:05 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Fabrice Gasnier <fabrice.gasnier@...s.st.com>
Cc:     William Breathitt Gray <vilhelm.gray@...il.com>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <kernel@...gutronix.de>, <a.fatoum@...gutronix.de>,
        <kamel.bouhara@...tlin.com>, <gwendal@...omium.org>,
        <alexandre.belloni@...tlin.com>, <david@...hnology.com>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <syednwaris@...il.com>,
        <patrick.havelange@...ensium.com>, <fabrice.gasnier@...com>,
        <mcoquelin.stm32@...il.com>, <alexandre.torgue@...com>,
        <o.rempel@...gutronix.de>, <jarkko.nikula@...ux.intel.com>
Subject: Re: [PATCH v16 01/14] counter: stm32-lptimer-cnt: Provide defines
 for clock polarities

On Tue, 31 Aug 2021 15:38:50 +0200
Fabrice Gasnier <fabrice.gasnier@...s.st.com> wrote:

> On 8/27/21 5:47 AM, William Breathitt Gray wrote:
> > The STM32 low-power timer permits configuration of the clock polarity
> > via the LPTIMX_CFGR register CKPOL bits. This patch provides
> > preprocessor defines for the supported clock polarities.
> > 
> > Cc: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
> > Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> > ---
> >  drivers/counter/stm32-lptimer-cnt.c | 6 +++---
> >  include/linux/mfd/stm32-lptimer.h   | 5 +++++
> >  2 files changed, 8 insertions(+), 3 deletions(-)  
> 
> Hi William,
> 
> You can add my:
> Reviewed-by: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
Applied to the togreg branch of iio.git and push out as testing for all the normal reasons

> 
> Thanks,
> Fabrice
> 
> > 
> > diff --git a/drivers/counter/stm32-lptimer-cnt.c b/drivers/counter/stm32-lptimer-cnt.c
> > index 13656957c45f..7367f46c6f91 100644
> > --- a/drivers/counter/stm32-lptimer-cnt.c
> > +++ b/drivers/counter/stm32-lptimer-cnt.c
> > @@ -140,9 +140,9 @@ static const enum counter_function stm32_lptim_cnt_functions[] = {
> >  };
> >  
> >  enum stm32_lptim_synapse_action {
> > -	STM32_LPTIM_SYNAPSE_ACTION_RISING_EDGE,
> > -	STM32_LPTIM_SYNAPSE_ACTION_FALLING_EDGE,
> > -	STM32_LPTIM_SYNAPSE_ACTION_BOTH_EDGES,
> > +	STM32_LPTIM_SYNAPSE_ACTION_RISING_EDGE = STM32_LPTIM_CKPOL_RISING_EDGE,
> > +	STM32_LPTIM_SYNAPSE_ACTION_FALLING_EDGE = STM32_LPTIM_CKPOL_FALLING_EDGE,
> > +	STM32_LPTIM_SYNAPSE_ACTION_BOTH_EDGES = STM32_LPTIM_CKPOL_BOTH_EDGES,
> >  	STM32_LPTIM_SYNAPSE_ACTION_NONE,
> >  };
> >  
> > diff --git a/include/linux/mfd/stm32-lptimer.h b/include/linux/mfd/stm32-lptimer.h
> > index 90b20550c1c8..06d3f11dc3c9 100644
> > --- a/include/linux/mfd/stm32-lptimer.h
> > +++ b/include/linux/mfd/stm32-lptimer.h
> > @@ -45,6 +45,11 @@
> >  #define STM32_LPTIM_PRESC	GENMASK(11, 9)
> >  #define STM32_LPTIM_CKPOL	GENMASK(2, 1)
> >  
> > +/* STM32_LPTIM_CKPOL */
> > +#define STM32_LPTIM_CKPOL_RISING_EDGE	0
> > +#define STM32_LPTIM_CKPOL_FALLING_EDGE	1
> > +#define STM32_LPTIM_CKPOL_BOTH_EDGES	2
> > +
> >  /* STM32_LPTIM_ARR */
> >  #define STM32_LPTIM_MAX_ARR	0xFFFF
> >  
> >