linux-kernel - Re: [for-next][PATCH 08/12] bootconfig: Fix missing return check of xbc_node_compose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210908152825.1a07d8b2@oasis.local.home>
Date:   Wed, 8 Sep 2021 15:28:25 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     linux-kernel@...r.kernel.org
Cc:     Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Julio Faracco <jcfaracco@...il.com>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [for-next][PATCH 08/12] bootconfig: Fix missing return check of
 xbc_node_compose_key function

On Wed, 08 Sep 2021 15:18:59 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: Julio Faracco <jcfaracco@...il.com>
> 
> The function `xbc_show_list should` handle the keys during the
> composition. Even the errors returned by the compose function. Instead
> of removing the `ret` variable, it should save the value and show the
> exact error. This missing variable is causing a compilation issue also.
> 
> Link: https://lkml.kernel.org/r/163077087861.222577.12884543474750968146.stgit@devnote2
> 
> Fixes: e5efaeb8a8f5 ("bootconfig: Support mixing a value and subkeys under a key")
> Signed-off-by: Julio Faracco <jcfaracco@...il.com>
> Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

> Cc: stable@...r.kernel.org

Oops, a typo. That should be: stable@...r.kernel.org or
stable@...nel.org. There is no "vgar" ;-)

I'll fix this up.

-- Steve


> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>