linux-kernel - Re: [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Sep 2021 15:57:46 +0300
From:   Kari Argillander <kari.argillander@...il.com>
To:     Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
Cc:     ntfs3@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000

On Thu, Sep 09, 2021 at 03:30:34PM +0300, Kari Argillander wrote:
> On Thu, Sep 09, 2021 at 01:58:04PM +0300, Konstantin Komarov wrote:
> > xfstest 041 works with 3003, so we need to

And it would be good to write generic/041. This way grepping is little
easier.

> > raise limit.
> 
> No need to linebreak.
> 
> > 
> > Signed-off-by: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
> > ---
> >  fs/ntfs3/ntfs.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/ntfs3/ntfs.h b/fs/ntfs3/ntfs.h
> > index 6bb3e595263b..0006481db7fa 100644
> > --- a/fs/ntfs3/ntfs.h
> > +++ b/fs/ntfs3/ntfs.h
> > @@ -21,7 +21,8 @@
> >  #define NTFS_NAME_LEN 255
> >  
> >  /* ntfs.sys used 500 maximum links on-disk struct allows up to 0xffff. */
> > -#define NTFS_LINK_MAX 0x400
> > +/* xfstest 041 creates 3003 hardlinks. */
> 
> It think comment is unnecessary here. If you think this is necassarry
> comment then please but it same comment block as last row.
> 
> > +#define NTFS_LINK_MAX 4000
> 
> What draw backs there is if this is 4000? We really do not care about
> xfstests if we have some reason to not do this. This info can be but
> to commit message.
> 
> >  //#define NTFS_LINK_MAX 0xffff
> 
> We can probably same time get rid of this.
> 
> >  
> >  /*
> > -- 
> > 2.28.0
> > 
>