linux-kernel - Re: [git pull] gfs2 setattr patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Sep 2021 19:46:53 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [git pull] gfs2 setattr patches

On Thu, Sep 09, 2021 at 12:41:33PM -0700, Linus Torvalds wrote:
> On Wed, Sep 8, 2021 at 9:27 PM Al Viro <viro@...iv.linux.org.uk> wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.gfs2
> >
> > for you to fetch changes up to d75b9fa053e4cd278281386d860c26fdbfbe9d03:
> >
> >   gfs2: Switch to may_setattr in gfs2_setattr (2021-08-13 00:41:05 -0400)
> 
> Explanation for what this series actually does?
> 
> I can see the shortlog, I can look at the commits, but I really want a
> summary in the pull request.

Basically, gfs2 has redo the permission checks after it grabs a cluster lock,
and they want to have that doable by call of shared helper, rather than
open-coding those checks.  Looks reasonable to me...