lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Sep 2021 08:48:53 +0200 From: Vincent Guittot <vincent.guittot@...aro.org> To: Daniel Jordan <daniel.m.jordan@...cle.com> Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>, Dietmar Eggemann <dietmar.eggemann@....com>, Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, Daniel Bristot de Oliveira <bristot@...hat.com>, Josh Don <joshdon@...gle.com>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] sched/fair: Fix se_is_idle() for !FAIR_GROUP_SCHED On Wed, 8 Sept 2021 at 22:40, Daniel Jordan <daniel.m.jordan@...cle.com> wrote: > > se_is_idle() unconditionally returns 0 for !FAIR_GROUP_SCHED. > > Check whether the task is SCHED_IDLE instead so buddies aren't set for > such tasks, as was the behavior before 304000390f88. > > Fixes: 304000390f88 ("sched: Cgroup SCHED_IDLE support") > Signed-off-by: Daniel Jordan <daniel.m.jordan@...cle.com> Reviewed-by: Vincent Guittot <vincent.guittot@...aro.org> > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index ff69f245b939..8b22665bc18e 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -497,7 +497,7 @@ static int cfs_rq_is_idle(struct cfs_rq *cfs_rq) > > static int se_is_idle(struct sched_entity *se) > { > - return 0; > + return task_has_idle_policy(task_of(se)); > } > > #endif /* CONFIG_FAIR_GROUP_SCHED */ > > base-commit: ac08b1c68d1b1ed3cebb218fc3ea2c07484eb07d > -- > 2.32.0 >
Powered by blists - more mailing lists