linux-kernel - Re: [PATCH] staging: r8188eu: Remove conditionals CONFIG_88EU_{AP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Sep 2021 12:01:51 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove conditionals
 CONFIG_88EU_{AP_MODE,P2P}

On Wed, Sep 08, 2021 at 12:01:09AM -0500, Larry Finger wrote:
> These two conditional compile symbols are explicitly defined.
> As a result, their included code is always compiled. They could be
> converted to Kconfig symbols; however, my experience with this driver
> in a GitHub repo is that many users of the device have it built into
> a SOC or SBC that they wish to use as an access point. As a result,
> CONFIG_88EU_APMODE would need to be selected. Thus it should be built in.
> 
> There have also been many users the wish to establish peer-to-peer
> networks with this device. For this reason, I am also proposing that
> CONFIG_88EU_P2P be automatically included.
> 
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>

Makes sense.  If this really does need to be split up in the future, it
can be done better without all of this #ifdef mess in the .c files.

thanks,

greg k-h