linux-kernel - Re: [PATCH v2 06/15] leds: trigger: blkdev: Add function to get gendisk by name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a69b13f-6f7e-98ba-7b9b-35bde571462e@gmail.com>
Date:   Fri, 10 Sep 2021 11:28:10 -0500
From:   Ian Pilcher <arequipeno@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     axboe@...nel.dk, pavel@....cz, linux-leds@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        kabel@...nel.org
Subject: Re: [PATCH v2 06/15] leds: trigger: blkdev: Add function to get
 gendisk by name

On 9/10/21 1:45 AM, Greg KH wrote:
> On Thu, Sep 09, 2021 at 05:25:04PM -0500, Ian Pilcher wrote:
>> +/* Must be built-in to access block_class */
>> +struct gendisk *ledtrig_blkdev_get_disk(const char *const name)
>> +{
>> +	struct device *dev;
>> +
>> +	dev = class_find_device(&block_class, NULL, name, blkdev_match_name);
>> +	if (dev == NULL)
>> +		return NULL;
> 
> You now have bumped the reference count on this structure.  Where do you
> decrement it when you are finished with it?

With context this time.  Sorry about that.


That happens when I "unlink" the block device from the LED in
blkdev_disk_unlink_locked() at ledtrig-blkdev.c:410.

(And also in the error path of link_device_store() at
ledtrig-blkdev.c:372.)

-- 
========================================================================
                  In Soviet Russia, Google searches you!
========================================================================