linux-kernel - RE: [PATCH v2 2/2] scsi: ufs: Add temperature notification exception handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR04MB657584129D49F3C90CA0C462FCD69@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Fri, 10 Sep 2021 16:32:20 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Guenter Roeck <linux@...ck-us.net>
CC:     "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bart Van Assche <bvanassche@....org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Bean Huo <beanhuo@...ron.com>
Subject: RE: [PATCH v2 2/2] scsi: ufs: Add temperature notification exception
 handling

> > +static void ufshcd_temp_exception_event_handler(struct ufs_hba *hba,
> > +u16 status) {
> > +     u32 value;
> > +
> > +     if (ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
> > +                           QUERY_ATTR_IDN_CASE_ROUGH_TEMP, 0, 0, &value))
> > +             return;
> > +
> > +     dev_info(hba->dev, "exception Tcase %d\n", value - 80);
> > +
> 
> It would probably make sense to call hwmon_notify_event() here.
Yes.  Thank you.

Thanks,
Avri

> 
> Guenter
> 
> > +     /*
> > +      * A placeholder for the platform vendors to add whatever additional
> > +      * steps required
> > +      */
> > +}
> > +
> >  static int __ufshcd_wb_toggle(struct ufs_hba *hba, bool set, enum
> > flag_idn idn)  {
> >       u8 index;
> > @@ -5821,6 +5837,9 @@ static void
> ufshcd_exception_event_handler(struct work_struct *work)
> >       if (status & hba->ee_drv_mask & MASK_EE_URGENT_BKOPS)
> >               ufshcd_bkops_exception_event_handler(hba);
> >
> > +     if (status & hba->ee_drv_mask & MASK_EE_URGENT_TEMP)
> > +             ufshcd_temp_exception_event_handler(hba, status);
> > +
> >       ufs_debugfs_exception_event(hba, status);
> >  out:
> >       ufshcd_scsi_unblock_requests(hba);
> > --
> > 2.17.1
> >