linux-kernel - Re: [PATCH 31/31] staging: wfx: indent functions arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 10 Sep 2021 19:57:43 +0300
From:   Kari Argillander <kari.argillander@...il.com>
To:     Jerome Pouiller <Jerome.Pouiller@...abs.com>
Cc:     devel@...verdev.osuosl.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH 31/31] staging: wfx: indent functions arguments

On Fri, Sep 10, 2021 at 06:05:04PM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller <jerome.pouiller@...abs.com>
> 
> Function arguments must be aligned with left parenthesis. Apply that
> rule.

To my eyes something still go wrong with this patch. Might be my email
fault, but every other patch looks ok. Now these are too left. Also it
should alight with first argument not left parenthesis?

> 
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@...abs.com>
> ---
>  drivers/staging/wfx/hif_tx_mib.c |  2 +-
>  drivers/staging/wfx/key.c        | 26 +++++++++++++-------------
>  2 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/wfx/hif_tx_mib.c b/drivers/staging/wfx/hif_tx_mib.c
> index 45e531d996bd..97e961e6bcf6 100644
> --- a/drivers/staging/wfx/hif_tx_mib.c
> +++ b/drivers/staging/wfx/hif_tx_mib.c
> @@ -75,7 +75,7 @@ int hif_get_counters_table(struct wfx_dev *wdev, int vif_id,
>  	} else {
>  		return hif_read_mib(wdev, vif_id,
>  				    HIF_MIB_ID_EXTENDED_COUNTERS_TABLE, arg,
> -				sizeof(struct hif_mib_extended_count_table));
> +				    sizeof(struct hif_mib_extended_count_table));
>  	}
>  }
>  
> diff --git a/drivers/staging/wfx/key.c b/drivers/staging/wfx/key.c
> index 51a528102016..65134a174683 100644
> --- a/drivers/staging/wfx/key.c
> +++ b/drivers/staging/wfx/key.c
> @@ -31,7 +31,7 @@ static void wfx_free_key(struct wfx_dev *wdev, int idx)
>  }
>  
>  static u8 fill_wep_pair(struct hif_wep_pairwise_key *msg,
> -			     struct ieee80211_key_conf *key, u8 *peer_addr)
> +			struct ieee80211_key_conf *key, u8 *peer_addr)
>  {
>  	WARN(key->keylen > sizeof(msg->key_data), "inconsistent data");
>  	msg->key_length = key->keylen;
> @@ -41,7 +41,7 @@ static u8 fill_wep_pair(struct hif_wep_pairwise_key *msg,
>  }
>  
>  static u8 fill_wep_group(struct hif_wep_group_key *msg,
> -			      struct ieee80211_key_conf *key)
> +			 struct ieee80211_key_conf *key)
>  {
>  	WARN(key->keylen > sizeof(msg->key_data), "inconsistent data");
>  	msg->key_id = key->keyidx;
> @@ -51,7 +51,7 @@ static u8 fill_wep_group(struct hif_wep_group_key *msg,
>  }
>  
>  static u8 fill_tkip_pair(struct hif_tkip_pairwise_key *msg,
> -			      struct ieee80211_key_conf *key, u8 *peer_addr)
> +			 struct ieee80211_key_conf *key, u8 *peer_addr)
>  {
>  	u8 *keybuf = key->key;
>  
> @@ -68,9 +68,9 @@ static u8 fill_tkip_pair(struct hif_tkip_pairwise_key *msg,
>  }
>  
>  static u8 fill_tkip_group(struct hif_tkip_group_key *msg,
> -			       struct ieee80211_key_conf *key,
> -			       struct ieee80211_key_seq *seq,
> -			       enum nl80211_iftype iftype)
> +			  struct ieee80211_key_conf *key,
> +			  struct ieee80211_key_seq *seq,
> +			  enum nl80211_iftype iftype)
>  {
>  	u8 *keybuf = key->key;
>  
> @@ -93,7 +93,7 @@ static u8 fill_tkip_group(struct hif_tkip_group_key *msg,
>  }
>  
>  static u8 fill_ccmp_pair(struct hif_aes_pairwise_key *msg,
> -			      struct ieee80211_key_conf *key, u8 *peer_addr)
> +			 struct ieee80211_key_conf *key, u8 *peer_addr)
>  {
>  	WARN(key->keylen != sizeof(msg->aes_key_data), "inconsistent data");
>  	ether_addr_copy(msg->peer_address, peer_addr);
> @@ -102,8 +102,8 @@ static u8 fill_ccmp_pair(struct hif_aes_pairwise_key *msg,
>  }
>  
>  static u8 fill_ccmp_group(struct hif_aes_group_key *msg,
> -			       struct ieee80211_key_conf *key,
> -			       struct ieee80211_key_seq *seq)
> +			  struct ieee80211_key_conf *key,
> +			  struct ieee80211_key_seq *seq)
>  {
>  	WARN(key->keylen != sizeof(msg->aes_key_data), "inconsistent data");
>  	memcpy(msg->aes_key_data, key->key, key->keylen);
> @@ -114,7 +114,7 @@ static u8 fill_ccmp_group(struct hif_aes_group_key *msg,
>  }
>  
>  static u8 fill_sms4_pair(struct hif_wapi_pairwise_key *msg,
> -			      struct ieee80211_key_conf *key, u8 *peer_addr)
> +			 struct ieee80211_key_conf *key, u8 *peer_addr)
>  {
>  	u8 *keybuf = key->key;
>  
> @@ -129,7 +129,7 @@ static u8 fill_sms4_pair(struct hif_wapi_pairwise_key *msg,
>  }
>  
>  static u8 fill_sms4_group(struct hif_wapi_group_key *msg,
> -			       struct ieee80211_key_conf *key)
> +			  struct ieee80211_key_conf *key)
>  {
>  	u8 *keybuf = key->key;
>  
> @@ -143,8 +143,8 @@ static u8 fill_sms4_group(struct hif_wapi_group_key *msg,
>  }
>  
>  static u8 fill_aes_cmac_group(struct hif_igtk_group_key *msg,
> -				   struct ieee80211_key_conf *key,
> -				   struct ieee80211_key_seq *seq)
> +			      struct ieee80211_key_conf *key,
> +			      struct ieee80211_key_seq *seq)
>  {
>  	WARN(key->keylen != sizeof(msg->igtk_key_data), "inconsistent data");
>  	memcpy(msg->igtk_key_data, key->key, key->keylen);
> -- 
> 2.33.0
>