linux-kernel - Re: [PATCH] staging: r8188eu: core: remove unused variable padapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Sep 2021 21:40:45 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Saurav Girepunje <saurav.girepunje@...il.com>,
        Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        gregkh@...uxfoundation.org, straube.linux@...il.com,
        fmdefrancesco@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Cc:     saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove unused variable padapter

On 9/10/21 21:31, Saurav Girepunje wrote:
> Remove unused variable padapter from mp_init_xmit_attrib().
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>

Reviewed-by: Pavel Skripkin <paskripkin@...il.com>

Thanks!

> ---
>   drivers/staging/r8188eu/core/rtw_mp.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_mp.c b/drivers/staging/r8188eu/core/rtw_mp.c
> index dabdd0406f30..8ac23d2112fb 100644
> --- a/drivers/staging/r8188eu/core/rtw_mp.c
> +++ b/drivers/staging/r8188eu/core/rtw_mp.c
> @@ -75,7 +75,7 @@ static void _init_mp_priv_(struct mp_priv *pmp_priv)
>   	memcpy(pnetwork->Ssid.Ssid, "mp_871x", pnetwork->Ssid.SsidLength);
>   }
> 
> -static void mp_init_xmit_attrib(struct mp_tx *pmptx, struct adapter *padapter)
> +static void mp_init_xmit_attrib(struct mp_tx *pmptx)
>   {
>   	struct pkt_attrib *pattrib;
>   	struct tx_desc *desc;
> @@ -107,7 +107,7 @@ s32 init_mp_priv(struct adapter *padapter)
>   	pmppriv->papdater = padapter;
> 
>   	pmppriv->tx.stop = 1;
> -	mp_init_xmit_attrib(&pmppriv->tx, padapter);
> +	mp_init_xmit_attrib(&pmppriv->tx);
> 
>   	switch (padapter->registrypriv.rf_config) {
>   	case RF_1T1R:
> --
> 2.32.0
> 


With regards,
Pavel Skripkin