linux-kernel - Re: [PATCH v2] perf list: Display hybrid pmu events with cpu type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59cf3fcb-e6cd-ddbe-84e5-6c3e85d575b4@linux.intel.com>
Date:   Fri, 10 Sep 2021 08:39:47 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Andi Kleen <ak@...ux.intel.com>, Ian Rogers <irogers@...gle.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v2] perf list: Display hybrid pmu events with cpu type



On 9/10/2021 6:56 AM, Andi Kleen wrote:
> 
> On 9/9/2021 3:37 PM, Ian Rogers wrote:
>> On Thu, Sep 2, 2021 at 7:54 PM Jin Yao <yao.jin@...ux.intel.com> wrote:
>>> Add a new option '--cputype' to perf-list to display core-only pmu events
>>> or atom-only pmu events.
>>>
>>> Each hybrid pmu event has been assigned with a pmu name, this patch
>>> compares the pmu name before listing the result.
>> Would this work more broadly for any PMU type? If so perhaps pmu
>> rather than cputype is a more appropriate option name?
> 
> It's not just the cpu pmu, because it still lists the uncore events, which makes sense.
> 
> If you want to match the pmu it probably would make sense to match it in the default matching for 
> non option arguments in perf list. But that would be a different patch.
> 
> -Andi
> 
> 

Yes, agree with Andi. Besides for cpu pmu events, it also lists the software events and uncore 
events. So probably cputype is an appropriate option name.

Thanks
Jin Yao