linux-kernel - Re: [PATCH] ASoC: mediatek: add required config dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Sep 2021 18:42:03 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Trevor Wu <trevor.wu@...iatek.com>, broonie@...nel.org,
        tiwai@...e.com, matthias.bgg@...il.com
Cc:     alsa-devel@...a-project.org, linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        geert@...ux-m68k.org, wenst@...omium.org,
        bicycle.tsai@...iatek.com, jiaxin.yu@...iatek.com,
        shane.chien@...iatek.com
Subject: Re: [PATCH] ASoC: mediatek: add required config dependency

On 9/8/21 11:55 PM, Trevor Wu wrote:
> Because SND_SOC_MT8195 depends on COMPILE_TEST, it's possible to build
> MT8195 driver in many different config combinations.
> Add all dependent config for SND_SOC_MT8195 in case some errors happen
> when COMPILE_TEST is enabled.
> 
> Signed-off-by: Trevor Wu <trevor.wu@...iatek.com>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.


> ---
>   sound/soc/mediatek/Kconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
> index 5a2f4667d50b..81ad2dcee9eb 100644
> --- a/sound/soc/mediatek/Kconfig
> +++ b/sound/soc/mediatek/Kconfig
> @@ -1,6 +1,7 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   config SND_SOC_MEDIATEK
>   	tristate
> +	select REGMAP_MMIO
>   
>   config SND_SOC_MT2701
>   	tristate "ASoC support for Mediatek MT2701 chip"
> @@ -188,7 +189,9 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
>   config SND_SOC_MT8195
>   	tristate "ASoC support for Mediatek MT8195 chip"
>   	depends on ARCH_MEDIATEK || COMPILE_TEST
> +	depends on COMMON_CLK
>   	select SND_SOC_MEDIATEK
> +	select MFD_SYSCON if SND_SOC_MT6359
>   	help
>   	  This adds ASoC platform driver support for Mediatek MT8195 chip
>   	  that can be used with other codecs.
> 


-- 
~Randy