linux-kernel - Re: [PATCH v6] Bluetooth: Keep MSFT ext info throughout a hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1E0E222B-4948-4584-B18D-C7010CC48841@holtmann.org>
Date:   Fri, 10 Sep 2021 09:27:50 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Manish Mandlik <mmandlik@...gle.com>
Cc:     Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        CrosBT Upstreaming <chromeos-bluetooth-upstreaming@...omium.org>,
        Alain Michaud <alainm@...omium.org>,
        Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
        Archie Pusaka <apusaka@...omium.org>,
        Miao-chen Chou <mcchou@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        open list <linux-kernel@...r.kernel.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v6] Bluetooth: Keep MSFT ext info throughout a hci_dev's
 life cycle

Hi Manish,

> This splits the msft_do_{open/close} to msft_do_{open/close} and
> msft_{register/unregister}. With this change it is possible to retain
> the MSFT extension info irrespective of controller power on/off state.
> This helps bluetoothd to report correct 'supported features' of the
> controller to the D-Bus clients event if the controller is off. It also
> re-reads the MSFT info upon every msft_do_open().
> 
> The following test steps were performed.
> 1. Boot the test device and verify the MSFT support debug log in syslog.
> 2. Power off the controller and read the 'supported features', power on
>   and read again.
> 3. Restart the bluetoothd and verify the 'supported features' value.
> 
> Signed-off-by: Miao-chen Chou <mcchou@...omium.org>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
> Reviewed-by: Archie Pusaka <apusaka@...omium.org>
> Reviewed-by: Alain Michaud <alainm@...omium.org>
> Signed-off-by: Manish Mandlik <mmandlik@...gle.com>
> ---
> 
> Changes in v6:
> - Split msft_do_{open/close} into msft_do_{open/close} and
>  msft_{register/unregister}
> 
> Changes in v5:
> - Rebase on ToT and remove extra blank line
> 
> Changes in v4:
> - Re-read the MSFT data instead of skipping if it's initiated already
> 
> Changes in v3:
> - Remove the accepted commits from the series
> 
> net/bluetooth/hci_core.c |  3 +++
> net/bluetooth/msft.c     | 55 +++++++++++++++++++++++++++++++++-------
> net/bluetooth/msft.h     |  4 +++
> 3 files changed, 53 insertions(+), 9 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel