linux-kernel - Re: [PATCH] staging: r8188eu: remove unused macro ROUND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210910073028.7p64fv4fxnpixwnx@viti.kaiser.cx>
Date:   Fri, 10 Sep 2021 09:30:28 +0200
From:   Martin Kaiser <martin@...ser.cx>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, fmdefrancesco@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unused macro ROUND

Thus wrote Michael Straube (straube.linux@...il.com):

> The macro ROUND is not used in the driver, remove it.
> Found with GCC -Wunused-macros.

> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
>  drivers/staging/r8188eu/core/rtw_security.c | 13 -------------
>  1 file changed, 13 deletions(-)

> diff --git a/drivers/staging/r8188eu/core/rtw_security.c b/drivers/staging/r8188eu/core/rtw_security.c
> index 82987255400a..db35f326bbb1 100644
> --- a/drivers/staging/r8188eu/core/rtw_security.c
> +++ b/drivers/staging/r8188eu/core/rtw_security.c
> @@ -1555,16 +1555,3 @@ const u8 rcons[] = {
>  	0x01, 0x02, 0x04, 0x08, 0x10, 0x20, 0x40, 0x80, 0x1B, 0x36
>  	/* for 128-bit blocks, Rijndael never uses more than 10 rcon values */
>  };
> -
> -/**
> - * Expand the cipher key into the encryption key schedule.
> - *
> - * @return	the number of rounds for the given cipher key size.
> - */
> -#define ROUND(i, d, s) \
> -do {									\
> -	d##0 = TE0(s##0) ^ TE1(s##1) ^ TE2(s##2) ^ TE3(s##3) ^ rk[4 * i]; \
> -	d##1 = TE0(s##1) ^ TE1(s##2) ^ TE2(s##3) ^ TE3(s##0) ^ rk[4 * i + 1]; \
> -	d##2 = TE0(s##2) ^ TE1(s##3) ^ TE2(s##0) ^ TE3(s##1) ^ rk[4 * i + 2]; \
> -	d##3 = TE0(s##3) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^ rk[4 * i + 3]; \
> -} while (0);
> -- 
> 2.33.0

I noticed this as well when a W=1 build brought up a warning about the
/** comment.

Acked-by: Martin Kaiser <martin@...ser.cx>