linux-kernel - Re: [PATCH] Bluetooth: hci: fix GPF in h5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <EF01F61D-7765-49C1-A813-55EB130FCCE1@holtmann.org>
Date:   Fri, 10 Sep 2021 09:39:14 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        apusaka@...omium.org, abhishekpandit@...omium.org,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+7d41312fe3f123a6f605@...kaller.appspotmail.com
Subject: Re: [PATCH] Bluetooth: hci: fix GPF in h5_recv

Hi Pavel,

> Syzbot hit general protection fault in h5_recv(). The problem was in
> missing NULL check.
> 
> hu->serdev can be NULL and we cannot blindly pass &serdev->dev
> somewhere, since it can cause GPF.
> 
> Fixes: d9dd833cf6d2 ("Bluetooth: hci_h5: Add runtime suspend")
> Reported-and-tested-by: syzbot+7d41312fe3f123a6f605@...kaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@...il.com>
> ---
> drivers/bluetooth/hci_h5.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel