linux-kernel - Re: [PATCH RESEND net] ice: Correctly deal with PFs that do not support RDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YTsjDsFbBggL2X/8@unreal>
Date:   Fri, 10 Sep 2021 12:19:10 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Dave Ertman <david.m.ertman@...el.com>
Cc:     davem@...emloft.net, kuba@...nel.org, yongxin.liu@...driver.com,
        shiraz.saleem@...el.com, anthony.l.nguyen@...el.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        jesse.brandeburg@...el.com, intel-wired-lan@...ts.osuosl.org,
        linux-rdma@...r.kernel.org, jgg@...pe.ca
Subject: Re: [PATCH RESEND net] ice: Correctly deal with PFs that do not
 support RDMA

On Thu, Sep 09, 2021 at 08:12:23AM -0700, Dave Ertman wrote:
> There are two cases where the current PF does not support RDMA
> functionality.  The first is if the NVM loaded on the device is set
> to not support RDMA (common_caps.rdma is false).  The second is if
> the kernel bonding driver has included the current PF in an active
> link aggregate.
> 
> When the driver has determined that this PF does not support RDMA, then
> auxiliary devices should not be created on the auxiliary bus. 

This part is wrong, auxiliary devices should always be created, in your case it
will be one eth device only without extra irdma device.

Your "bug" is that you mixed auxiliary bus devices with "regular" ones
and created eth device not as auxiliary one. This is why you are calling
to auxiliary_device_init() for RDMA only and fallback to non-auxiliary mode.

I hope that this is simple mistake while Intel folks rushed to merge irdma
and not deliberate decision to find a way to support out-of-tree drivers.

As a reminder, the whole idea of auxiliary bus is to have small,
independent vendor driver core logic that manages capabilities and
based on that creates/removes sub-devices (eth, rdma, vdpa ...), so
driver core can properly load/unload their respective drivers.

Thanks