linux-kernel - Re: [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YTssJkXH/ATm9zaA@zn.tnic>
Date:   Fri, 10 Sep 2021 11:57:58 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     "Chatradhi, Naveen Krishna" <nchatrad@....com>,
        platform-driver-x86@...r.kernel.org
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        x86@...nel.org, linux@...ck-us.net, yazen.ghannam@....com,
        mingo@...hat.com, nathan.fontenot@....com, lewis.carroll@....com,
        Ingo Molnar <mingo@...nel.org>,
        Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access

On Wed, Sep 08, 2021 at 10:41:20PM +0530, Chatradhi, Naveen Krishna wrote:
> In all the future server platforms, AMD's direction is the support HSMP
> interface, which exposes system management knobs.

I know you all think about the future only but there's the past too and
there's a bunch of AMD hardware out there which doesn't have that.

> > You could make it a separate driver module called amd_hsmp.ko which
> > loads only on the appropriate hw and uses amd_nb.c for detection only
> > like the other drivers, for example.
> 
> How about, creating a module under drivers/platform/x86/ (lets say
> amd_hsmp.c) export an API from here and it can be extended to support all
> the knobs that does not fit in an existing frameworks (such as hwmon, etc)
> and provide a user space access.
> 
> I can see similar references in the drivers/platform/x86/ directory.

That sounds ok to me too. There's also arch/x86/platform/, btw, and I
still have to find out what the difference is. :-)

Lemme add the platform drivers folks.

Thread begins at:

https://lkml.kernel.org/r/20210902174155.7365-1-nchatrad@amd.com

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette