linux-kernel - Re: [PATCHv6 0/8] videobuf2: support new noncontiguous DMA API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Sep 2021 19:00:57 +0900
From:   Tomasz Figa <tfiga@...omium.org>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>
Cc:     Hans Verkuil <hverkuil-cisco@...all.nl>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Dafna Hirschfeld <dafna.hirschfeld@...labora.com>,
        Ricardo Ribalda <ribalda@...omium.org>,
        Christoph Hellwig <hch@....de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv6 0/8] videobuf2: support new noncontiguous DMA API

Hi Sergey,

On Thu, Sep 9, 2021 at 8:24 PM Sergey Senozhatsky
<senozhatsky@...omium.org> wrote:
>
> Hello,
>
>         The series adds support for noncontiguous DMA API and
> V4L2_MEMORY_FLAG_NON_COHERENT UAPI.
>
> v5:
>
> https://lore.kernel.org/lkml/20210823122235.116189-1-senozhatsky@chromium.org/
>
> -- addressed feedback (Tomasz)
> -- reworked prepare/finish functions (Tomasz)
>
> Sergey Senozhatsky (8):
>   videobuf2: rework vb2_mem_ops API
>   videobuf2: inverse buffer cache_hints flags
>   videobuf2: split buffer cache_hints initialisation
>   videobuf2: move cache_hints handling to allocators
>   videobuf2: add V4L2_MEMORY_FLAG_NON_COHERENT flag
>   videobuf2: add queue memory coherency parameter
>   videobuf2: handle V4L2_MEMORY_FLAG_NON_COHERENT flag
>   videobuf2: handle non-contiguous DMA allocations
>
>  .../userspace-api/media/v4l/buffer.rst        |  40 +++-
>  .../media/v4l/vidioc-create-bufs.rst          |   7 +-
>  .../media/v4l/vidioc-reqbufs.rst              |  16 +-
>  .../media/common/videobuf2/videobuf2-core.c   | 126 +++++++----
>  .../common/videobuf2/videobuf2-dma-contig.c   | 195 ++++++++++++++----
>  .../media/common/videobuf2/videobuf2-dma-sg.c |  39 ++--
>  .../media/common/videobuf2/videobuf2-v4l2.c   |  59 +++---
>  .../common/videobuf2/videobuf2-vmalloc.c      |  30 +--
>  drivers/media/dvb-core/dvb_vb2.c              |   2 +-
>  drivers/media/v4l2-core/v4l2-compat-ioctl32.c |   9 +-
>  drivers/media/v4l2-core/v4l2-ioctl.c          |   4 +-
>  include/media/videobuf2-core.h                |  59 +++---
>  include/uapi/linux/videodev2.h                |  11 +-
>  13 files changed, 411 insertions(+), 186 deletions(-)

Thanks a lot for working on this. This version looks good to me.

Acked-by: Tomasz Figa <tfiga@...omium.org>

Best regards,
Tomasz