linux-kernel - Re: [PATCH 4/8] dt-bindings: clock: arm,syscon-icst: Use 'reg' instead of 'vco-offset' for VCO register address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Sep 2021 08:11:55 -0500
From:   Rob Herring <robh@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>, Pavel Machek <pavel@....cz>
Cc:     Liviu Dudau <liviu.dudau@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        Michael Turquette <mturquette@...libre.com>
Subject: Re: [PATCH 4/8] dt-bindings: clock: arm,syscon-icst: Use 'reg'
 instead of 'vco-offset' for VCO register address

On Thu, Sep 9, 2021 at 4:31 PM Rob Herring <robh@...nel.org> wrote:
>
> 'reg' is the standard property for defining register banks/addresses. Add
> it to use for the VCO register address and deprecate 'vco-offset'. This
> will also allow for using standard node names with unit-addresses.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-clk@...r.kernel.org
> Cc: Michael Turquette <mturquette@...libre.com>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index 118c5543e037..c346287ca15d 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -69,6 +69,10 @@ properties:
>        - arm,impd1-vco1
>        - arm,impd1-vco2
>
> +  reg:
> +    maxItems: 1
> +    description: The VCO register
> +
>    clocks:
>      description: Parent clock for the ICST VCO
>      maxItems: 1
> @@ -83,6 +87,7 @@ properties:
>    vco-offset:
>      $ref: '/schemas/types.yaml#/definitions/uint32'
>      description: Offset to the VCO register for the oscillator
> +    deprecated

Sigh, that should be 'deprecated: true'.

Rob