linux-kernel - Re: [PATCH 0/3] perf report: Add support to print a textual representation of IBS raw sample data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YTth5DLWGbyAzxvQ@kernel.org>
Date:   Fri, 10 Sep 2021 10:47:16 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Kim Phillips <kim.phillips@....com>
Cc:     Arnaldo Carvalho de Melo <acme@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Ian Rogers <irogers@...gle.com>,
        Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...hat.com>,
        Joao Martins <joao.m.martins@...cle.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Mark Rutland <mark.rutland@....com>,
        Michael Petlan <mpetlan@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Robert Richter <robert.richter@....com>,
        Stephane Eranian <eranian@...gle.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 0/3] perf report: Add support to print a textual
 representation of IBS raw sample data

Em Thu, Sep 09, 2021 at 04:58:12PM -0500, Kim Phillips escreveu:
> Hi Arnaldo,
> 
> Can you please take a look at applying this series?  Its kernel-side
> dependent series has already been applied and is in Linus' master.

Sure, I'm now trying to fix this:

  CC      /tmp/build/perf/util/amd-sample-raw.o
util/amd-sample-raw.c: In function ‘evlist__amd_sample_raw’:
util/amd-sample-raw.c:125:42: error: ‘ bytes’ directive output may be truncated writing 6 bytes into a region of size between 4 and 7 [-Werror=format-truncation=]
  125 |                          " OpMemWidth %2d bytes", 1 << (reg.op_mem_width - 1));
      |                                          ^~~~~~
In file included from /usr/include/stdio.h:866,
                 from util/amd-sample-raw.c:7:
/usr/include/bits/stdio2.h:71:10: note: ‘__builtin___snprintf_chk’ output between 21 and 24 bytes into a destination of size 21
   71 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   72 |                                    __glibc_objsize (__s), __fmt,
      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   73 |                                    __va_arg_pack ());
      |                                    ~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/util/amd-sample-raw.o] Error 1
 
> Thanks,
> 
> Kim
> 
> On 8/17/21 5:15 PM, Kim Phillips wrote:
> > Hello Linux perf tools users and maintainers,
> > 
> > The first patch in this series prepares the perf tool to support
> > retrieving cpuid and pmu_mappings data when in report mode,
> > information that is needed to accurately decode IBS data.
> > 
> > The second patch adds a header file tools/arch/x86/include/asm/amd-ibs.h
> > from a separate kernel-side submittion [1].
> > 
> > The third patch allows the tool to print a textual representation
> > of the sample data recorded by IBS.
> > 
> > [1] https://lore.kernel.org/lkml/20210817221048.88063-9-kim.phillips@amd.com
> > 
> > Kim Phillips (3):
> >    perf env: Add perf_env__cpuid, perf_env__{nr_}pmu_mappings
> >    perf report: Add tools/arch/x86/include/asm/amd-ibs.h
> >    perf report: Add support to print a textual representation of IBS raw
> >      sample data
> > 
> >   tools/arch/x86/include/asm/amd-ibs.h | 132 ++++++++++++
> >   tools/perf/check-headers.sh          |   1 +
> >   tools/perf/util/Build                |   1 +
> >   tools/perf/util/amd-sample-raw.c     | 290 +++++++++++++++++++++++++++
> >   tools/perf/util/env.c                |  78 +++++++
> >   tools/perf/util/env.h                |   5 +
> >   tools/perf/util/sample-raw.c         |   8 +
> >   tools/perf/util/sample-raw.h         |   6 +-
> >   8 files changed, 520 insertions(+), 1 deletion(-)
> >   create mode 100644 tools/arch/x86/include/asm/amd-ibs.h
> >   create mode 100644 tools/perf/util/amd-sample-raw.c
> > 
> > Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> > Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> > Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> > Cc: Ian Rogers <irogers@...gle.com>
> > Cc: Ingo Molnar <mingo@...hat.com>
> > Cc: Jiri Olsa <jolsa@...hat.com>
> > Cc: Joao Martins <joao.m.martins@...cle.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> > Cc: Mark Rutland <mark.rutland@....com>
> > Cc: Michael Petlan <mpetlan@...hat.com>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Robert Richter <robert.richter@....com>
> > Cc: Stephane Eranian <eranian@...gle.com>
> > Cc: linux-kernel@...r.kernel.org
> > Cc: linux-perf-users@...r.kernel.org
> > 

-- 

- Arnaldo