linux-kernel - Re: [PATCH v2 09/15] leds: trigger: blkdev: Check devices for activity and blink LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210910171211.3c2236c3@thinkpad>
Date:   Fri, 10 Sep 2021 17:12:11 +0200
From:   Marek Behún <kabel@...nel.org>
To:     Ian Pilcher <arequipeno@...il.com>
Cc:     axboe@...nel.dk, pavel@....cz, linux-leds@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH v2 09/15] leds: trigger: blkdev: Check devices for
 activity and blink LEDs

On Fri, 10 Sep 2021 10:09:09 -0500
Ian Pilcher <arequipeno@...il.com> wrote:

> On 9/9/21 9:17 PM, Marek Behún wrote:
> > So your code allows me to use a partition block device (like sda2) to
> > register with the blkdev LED trigger, but when I do this, the code will
> > disregard that I just want the LED to blink on activity on that one
> > partition. Instead you will blink for whole sda, since you are looking
> > at stats of only part0.
> > 
> > Am I right?  
> 
> You can't add partitions, only whole devices.

But I should be able to, since partition is a block device in /dev.
Any block device from /sys/class/block should be possible to add.

Marek