linux-kernel - Re: [PATCH v3 1/3] dt-bindings: aspeed: Add UART routing controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLdT3U2k8Znjo0LHUtC41vPidR4ZDDhcRPpxDC7atgEug@mail.gmail.com>
Date:   Fri, 10 Sep 2021 10:57:43 -0500
From:   Rob Herring <robh@...nel.org>
To:     ChiaWei Wang <chiawei_wang@...eedtech.com>
Cc:     "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
        "yulei.sh@...edance.com" <yulei.sh@...edance.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "joel@....id.au" <joel@....id.au>,
        "osk@...gle.com" <osk@...gle.com>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "andrew@...id.au" <andrew@...id.au>
Subject: Re: [PATCH v3 1/3] dt-bindings: aspeed: Add UART routing controller

On Thu, Sep 9, 2021 at 8:38 PM ChiaWei Wang <chiawei_wang@...eedtech.com> wrote:
>
> Hi Rob,
>
> > From: Rob Herring <robh@...nel.org>
> > Sent: Thursday, September 9, 2021 8:33 PM
> >
> > On Thu, 09 Sep 2021 18:29:05 +0800, Chia-Wei Wang wrote:
> > > Add dt-bindings for Aspeed UART routing controller.
> > >
> > > Signed-off-by: Oskar Senft <osk@...gle.com>
> > > Signed-off-by: Chia-Wei Wang <chiawei_wang@...eedtech.com>
> > > ---
> > >  .../bindings/soc/aspeed/uart-routing.yaml     | 70
> > +++++++++++++++++++
> > >  1 file changed, 70 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m
> > dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/soc/aspeed/uart-routing.example.dt.yaml:
> > 0:0: /example-0/lpc@...89000: failed to match any schema with compatible:
> > ['aspeed,ast2600-lpc-v2', 'simple-mfd', 'syscon']
>
> The "aspeed,ast2600-lpc-v2" compatible string is described in the .txt file 'aspeed-lpc.txt'.
> Do we have to firstly convert the text file into YAML one to resolve this dependency issue?

Yes. This is a significant change to the LPC block binding.

Rob