linux-kernel - Re: [PATCH] x86/umip: Add a umip= cmdline switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YTx0+0pfyzHuX80L@zn.tnic>
Date:   Sat, 11 Sep 2021 11:20:59 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
Cc:     X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        Marcus Rückert <mrueckert@...e.com>
Subject: Re: [PATCH] x86/umip: Add a umip= cmdline switch

On Fri, Sep 10, 2021 at 06:14:59PM -0700, Ricardo Neri wrote:
> If it is printing the same information again and again, wouldn't it be
> simpler to have a umip_pr_warn_once()?

If you do a once thing, you're blocking any other programs from warning,
output you probably wanna see.

With the command line switch you do the same but you're at least pushing
the user to become active and do it first. I.e., with enabling that
option, the user basically says that she/he is not interested in any of
that output and that is ok.

The optimal thing would be to ratelimit it per process but that would be
an overkill and not really needed.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette