[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <58796c32-5105-b3a3-fdeb-bf38e97ecd6b@gmail.com>
Date: Sat, 11 Sep 2021 15:32:35 +0200
From: Michael Straube <straube.linux@...il.com>
To: Martin Kaiser <martin@...ser.cx>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Larry Finger <Larry.Finger@...inger.net>,
Phillip Potter <phil@...lpotter.co.uk>,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove write-only variable
bLCKInProgress
On 9/11/21 15:23, Martin Kaiser wrote:
> bLCKInProgress in struct odm_rf_cal is never read. Remove it.
>
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 4 ----
> drivers/staging/r8188eu/include/odm.h | 1 -
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> index 6e0abaf58791..d9693c8014ce 100644
> --- a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> +++ b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> @@ -1212,16 +1212,12 @@ void PHY_LCCalibrate_8188E(struct adapter *adapt)
> timecount += 50;
> }
>
> - dm_odm->RFCalibrateInfo.bLCKInProgress = true;
> -
> if (dm_odm->RFType == ODM_2T2R) {
> phy_LCCalibrate_8188E(adapt, true);
> } else {
> /* For 88C 1T1R */
> phy_LCCalibrate_8188E(adapt, false);
> }
> -
> - dm_odm->RFCalibrateInfo.bLCKInProgress = false;
> }
>
> static void phy_setrfpathswitch_8188e(struct adapter *adapt, bool main, bool is2t)
> diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
> index 7c8f082930dd..cda8b3ffe0be 100644
> --- a/drivers/staging/r8188eu/include/odm.h
> +++ b/drivers/staging/r8188eu/include/odm.h
> @@ -679,7 +679,6 @@ struct odm_rf_cal {
> u32 Reg864;
>
> bool bIQKInitialized;
> - bool bLCKInProgress;
> bool bAntennaDetected;
> u32 ADDA_backup[IQK_ADDA_REG_NUM];
> u32 IQK_MAC_backup[IQK_MAC_REG_NUM];
>
Compiles and looks good to me, thanks.
Acked-by: Michael Straube <straube.linux@...il.com>
Powered by blists - more mailing lists