linux-kernel - Re: [PATCH peterz-queue:sched/core] sched: fix build warning with W=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALOAHbCwnAiw+A0z2NvjT1z55kxCRmiF-pHdMSm1iTG1O_bHpA@mail.gmail.com>
Date:   Sat, 11 Sep 2021 22:47:52 +0800
From:   Yafang Shao <laoar.shao@...il.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     kbuild test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH peterz-queue:sched/core] sched: fix build warning with W=1

On Sat, Sep 11, 2021 at 8:22 PM Peter Zijlstra <peterz@...radead.org> wrote:
>
> On Sat, Sep 11, 2021 at 08:25:05AM +0000, Yafang Shao wrote:
> > kernel test robot reported some build warnings with W=1 as below,
> >
> > kernel/sched/fair.c:892:34: warning: variable 'stats' set but not used
> > kernel/sched/core.c:10238:42: warning: variable 'stats' set but not used
> > kernel/sched/fair.c:893:29: warning: variable 'p' set but not used
> > kernel/sched/rt.c:1292:29: warning: variable 'p' set but not used
> > kernel/sched/deadline.c:1486:34: warning: variable 'stats' set but not used
> > arch/nds32/include/asm/current.h:10:13: warning: variable '$r25' set but not used
> >
> > These warnings happen when CONFIG_SCHEDSTATS is not set, in which
> > case the schedstat_* functions will be none. We should add
> > '__maybe_unused' to fix it
>
> I really hate all of this, I think the compiler is just being unhelpful
> in the extreme. Also, I spupose the warning is in W=1 for a reason,
> let's just completely ignore all of this.

Got it.
Thanks for the review.

-- 
Thanks
Yafang