linux-kernel - Re: [PATCH] kvm: x86: i8259: Converts mask values to logical binary values.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7CE1178D-729E-400A-A8D5-C8A9CD1BEE26@zytor.com>
Date:   Fri, 10 Sep 2021 20:32:59 -0700
From:   "H. Peter Anvin" <hpa@...or.com>
To:     18341265598@....com, Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org
CC:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zhaoge Zhang <18341265598@....com>
Subject: Re: [PATCH] kvm: x86: i8259: Converts mask values to logical binary values.

! is already booleanizing. There is no need to use !!!.

On September 10, 2021 8:27:21 PM PDT, 18341265598@....com wrote:
>From: Zhaoge Zhang <18341265598@....com>
>
>Signed-off-by: Zhaoge Zhang <18341265598@....com>
>---
> arch/x86/kvm/i8259.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c
>index 0b80263..a8f1d60 100644
>--- a/arch/x86/kvm/i8259.c
>+++ b/arch/x86/kvm/i8259.c
>@@ -92,7 +92,7 @@ static inline int pic_set_irq1(struct kvm_kpic_state *s, int irq, int level)
> 	mask = 1 << irq;
> 	if (s->elcr & mask)	/* level triggered */
> 		if (level) {
>-			ret = !(s->irr & mask);
>+			ret = !!!(s->irr & mask);
> 			s->irr |= mask;
> 			s->last_irr |= mask;
> 		} else {
>@@ -102,7 +102,7 @@ static inline int pic_set_irq1(struct kvm_kpic_state *s, int irq, int level)
> 	else	/* edge triggered */
> 		if (level) {
> 			if ((s->last_irr & mask) == 0) {
>-				ret = !(s->irr & mask);
>+				ret = !!!(s->irr & mask);
> 				s->irr |= mask;
> 			}
> 			s->last_irr |= mask;

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.