lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 12 Sep 2021 17:43:24 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Denis Pauk <pauk.denis@...il.com> Cc: Andy Shevchenko <andriy.shevchenko@...el.com>, Bernhard Seibold <mail@...nhard-seibold.de>, Guenter Roeck <linux@...ck-us.net>, Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/3] hwmon: (nct6775) Use sio_data in superio_* (v2) On Sun, Sep 12, 2021 at 1:26 AM Denis Pauk <pauk.denis@...il.com> wrote: > On Thu, 9 Sep 2021 19:50:02 +0300 > Andy Shevchenko <andriy.shevchenko@...el.com> wrote: > > On Thu, Sep 09, 2021 at 12:36:02AM +0300, Denis Pauk wrote: ... > Should it be such ? I don't know, but if so, then SoB of Bernhard is missing below. It's all written in the Submitting Patches document: https://www.kernel.org/doc/html/latest/process/submitting-patches.html > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204807 > Signed-off-by: Denis Pauk <pauk.denis@...il.com> > Co-Developed-by: Bernhard Seibold <mail@...nhard-seibold.de> ... > > > + int sioreg; > > > > It should be unsigned short. > Should I change all occurrences of sioreg to unsigned short? > Before my patch it was integer. Ah, then it's fine. Keep the same type then as is. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists