linux-kernel - Re: sound/isa/es1688/es1688_lib.c:384:79: error: 'DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3mMH8s3tzeUhO4Z22-YYzRv5mExj=yY9hBwkGoMriSpg@mail.gmail.com>
Date:   Mon, 13 Sep 2021 15:51:26 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        kernel test robot <lkp@...el.com>,
        Arnd Bergmann <arnd@...db.de>, kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Ungerer <gerg@...ux-m68k.org>
Subject: Re: sound/isa/es1688/es1688_lib.c:384:79: error: 'DMA_AUTOINIT' undeclared

On Mon, Sep 13, 2021 at 9:55 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> > CONFIG_ISA_DMA_API=y
> > but CONFIG_ISA is not set.
> > (Yes, this is ColdFire.)
> >
> > menuconfig SND_ISA
> >         bool "ISA sound devices"
> >         depends on ISA || COMPILE_TEST
> >         depends on ISA_DMA_API
> >         default y
> >
> > I suppose that we could drop the "|| COMPILE_TEST" part.
>
> Or "... || (COMPILE_TEST && !M68K)"?

I think both approaches still fail for Q40 and AMIGA_PCMCIA,
which also set CONFIG_ISA, but still don't provide that
symbol.

AFAICT, we instead need

          depends on ISA_DMA_API && !M68K

The COMPILE_TEST can stay then, though it would
not be a huge loss to remove that.

       Arnd