linux-kernel - Re: [PATCH -next v2] bpf: Add oversize check before call kvcalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39ffe740-0092-61ee-5af7-8de41b5700c0@fb.com>
Date:   Sun, 12 Sep 2021 19:25:02 -0700
From:   Yonghong Song <yhs@...com>
To:     Bixuan Cui <cuibixuan@...wei.com>, <bpf@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <ast@...nel.org>, <daniel@...earbox.net>, <andrii@...nel.org>,
        <kafai@...com>, <songliubraving@...com>,
        <john.fastabend@...il.com>, <kpsingh@...nel.org>
Subject: Re: [PATCH -next v2] bpf: Add oversize check before call kvcalloc()



On 9/10/21 5:55 PM, Bixuan Cui wrote:
> Commit 7661809d493b ("mm: don't allow oversized kvmalloc() calls") add the
> oversize check. When the allocation is larger than what kmalloc() supports,
> the following warning triggered:
> 
> WARNING: CPU: 0 PID: 8408 at mm/util.c:597 kvmalloc_node+0x108/0x110 mm/util.c:597
> Modules linked in:
> CPU: 0 PID: 8408 Comm: syz-executor221 Not tainted 5.14.0-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> RIP: 0010:kvmalloc_node+0x108/0x110 mm/util.c:597
> Call Trace:
>   kvmalloc include/linux/mm.h:806 [inline]
>   kvmalloc_array include/linux/mm.h:824 [inline]
>   kvcalloc include/linux/mm.h:829 [inline]
>   check_btf_line kernel/bpf/verifier.c:9925 [inline]
>   check_btf_info kernel/bpf/verifier.c:10049 [inline]
>   bpf_check+0xd634/0x150d0 kernel/bpf/verifier.c:13759
>   bpf_prog_load kernel/bpf/syscall.c:2301 [inline]
>   __sys_bpf+0x11181/0x126e0 kernel/bpf/syscall.c:4587
>   __do_sys_bpf kernel/bpf/syscall.c:4691 [inline]
>   __se_sys_bpf kernel/bpf/syscall.c:4689 [inline]
>   __x64_sys_bpf+0x78/0x90 kernel/bpf/syscall.c:4689
>   do_syscall_x64 arch/x86/entry/common.c:50 [inline]
>   do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
>   entry_SYSCALL_64_after_hwframe+0x44/0xae
> 
> Reported-by: syzbot+f3e749d4c662818ae439@...kaller.appspotmail.com
> Signed-off-by: Bixuan Cui <cuibixuan@...wei.com>

Acked-by: Yonghong Song <yhs@...com>