linux-kernel - RE: [PATCH v4 1/2] scsi: ufs: Probe for temperature notification support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR04MB6575C0E14F4C6BF0000B770FFCD99@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Mon, 13 Sep 2021 15:29:00 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Guenter Roeck <linux@...ck-us.net>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bart Van Assche <bvanassche@....org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Bean Huo <beanhuo@...ron.com>
Subject: RE: [PATCH v4 1/2] scsi: ufs: Probe for temperature notification
 support

> > +
> > +static bool ufs_read_temp_enable(struct ufs_hba *hba, u8 mask) {
> > +     u32 ee_mask;
> > +
> > +     if (ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
> QUERY_ATTR_IDN_EE_CONTROL, 0, 0,
> > +                           &ee_mask))
> > +             return false;
> 
> That should probably return the error code from ufshcd_query_attr(). I don't
> see a good reason to ignore it.
Done.

> 
> > +
> > +     return (mask & ee_mask & MASK_EE_TOO_HIGH_TEMP) || (mask &
> > +ee_mask & MASK_EE_TOO_LOW_TEMP); }
> > +
> > +static int ufs_get_temp(struct ufs_hba *hba, enum attr_idn idn, long
> > +*val) {
> > +     u32 value;
> > +
> > +     if (ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR, idn, 0,
> 0, &value))
> > +             return -EINVAL;
> 
> ufshcd_query_attr() already returns a valid Linux error code. It should be
> returned and not be overwritten. Besides, -EINVAL is wrong in most cases. It
> is only an acceptable error code if parameters passed to ufshcd_query_attr()
> are wrong, which is surely not the case here.
Done.

> 
> > +
> > +     if (value == 0)
> > +             return -EINVAL;
> 
> As mentioned in my other response, this is expected if the sensor is
> disabled, and thus should return -ENODATA.
Done.

Thanks,
Avri