linux-kernel - Re: [PATCH 0/4] staging: r8188eu: more power management cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YT96vEoZmj89GMBJ@kroah.com>
Date:   Mon, 13 Sep 2021 18:22:20 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] staging: r8188eu: more power management cleanup

On Sat, Sep 11, 2021 at 06:10:15PM +0200, Martin Kaiser wrote:
> bHWPwrPindetect is always 0 for the r8188eu driver. This makes a lot of
> code unreachable.
> 
> Tested with Edimax EW-7811Un V2 on an ARM32 embedded system.
> 
> Martin Kaiser (4):
>   staging: r8188eu: bHWPwrPindetect is always false
>   staging: r8188eu: brfoffbyhw is always false
>   staging: r8188eu: remove rtw_hw_suspend
>   staging: r8188eu: remove rtw_hw_resume
> 
>  drivers/staging/r8188eu/core/rtw_cmd.c        | 10 --
>  drivers/staging/r8188eu/core/rtw_pwrctrl.c    | 20 ----
>  .../staging/r8188eu/hal/rtl8188e_hal_init.c   |  4 +-
>  drivers/staging/r8188eu/hal/usb_halinit.c     | 14 ---
>  drivers/staging/r8188eu/include/osdep_intf.h  |  2 -
>  drivers/staging/r8188eu/include/rtw_pwrctrl.h |  2 -
>  drivers/staging/r8188eu/os_dep/ioctl_linux.c  |  7 --
>  drivers/staging/r8188eu/os_dep/usb_intf.c     | 99 -------------------
>  8 files changed, 2 insertions(+), 156 deletions(-)
> 
> -- 
> 2.20.1
> 
> 

I have applied 2 of these, please rebase and resend the rest.

thanks,

greg k-h