linux-kernel - Re: [PATCH AUTOSEL 5.14 044/252] staging: rtl8188eu: remove rtw_wx_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YT979kMB0rOJeqZO@sashalap>
Date:   Mon, 13 Sep 2021 12:27:34 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Phillip Potter <phil@...lpotter.co.uk>,
        kernel test robot <lkp@...el.com>,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH AUTOSEL 5.14 044/252] staging: rtl8188eu: remove
 rtw_wx_set_rate handler function

On Thu, Sep 09, 2021 at 01:48:49PM +0200, Greg Kroah-Hartman wrote:
>On Thu, Sep 09, 2021 at 07:37:38AM -0400, Sasha Levin wrote:
>> From: Phillip Potter <phil@...lpotter.co.uk>
>>
>> [ Upstream commit ac5951a6e3d50cfa861ea83baa2ec15d994389cb ]
>>
>> Remove rtw_wx_set_rate handler function, which currently handles the
>> SIOCSIWRATE wext ioctl. This function (although containing a lot of
>> code) set nothing outside its own local variables, and did nothing other
>> than call a now removed debugging statement repeatedly. Removing it and
>> leaving its associated entry in rtw_handlers as NULL is therefore the
>> better option. Removing this function also fixes a kernel test robot
>> warning.
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
>> Link: https://lore.kernel.org/r/20210625191658.1299-1-phil@philpotter.co.uk
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> ---
>>  .../staging/rtl8188eu/os_dep/ioctl_linux.c    | 75 -------------------
>>  1 file changed, 75 deletions(-)
>
>This whole driver is now gone in 5.15-rc1, so no need for doing anything
>like this for older kernels.  Please drop this patch from all branches.

Dropped, thanks!

-- 
Thanks,
Sasha