linux-kernel - Re: [PATCH 1/2] dt-bindings: usb: atmel: add USB PHY type property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Sep 2021 16:38:42 +0000
From:   <Cristian.Birsan@...rochip.com>
To:     <sergei.shtylyov@...il.com>, <stern@...land.harvard.edu>,
        <gregkh@...uxfoundation.org>, <Nicolas.Ferre@...rochip.com>,
        <ada@...rsis.com>, <alexandre.belloni@...tlin.com>,
        <Ludovic.Desroches@...rochip.com>
CC:     <linux-usb@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: usb: atmel: add USB PHY type property

Hi Sergei,

On 9/10/21 10:07 PM, Sergei Shtylyov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hello!
> 
> On 9/10/21 7:38 PM, cristian.birsan@...rochip.com wrote:
> 
>> From: Cristian Birsan <cristian.birsan@...rochip.com>
>>
>> Add USB PHY type property for controllers with HSIC support.
>>
>> Signed-off-by: Cristian Birsan <cristian.birsan@...rochip.com>
>> ---
>>  Documentation/devicetree/bindings/usb/atmel-usb.txt | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt
>> index a4002624ba14..f512f0290728 100644
>> --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt
>> +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt
>> @@ -39,6 +39,10 @@ Required properties:
>>               "ehci_clk" for the peripheral clock
>>               "usb_clk" for the UTMI clock
>>
>> +Optional properties:
>> + - phy_type : For multi port host USB controllers, should be one of
> 
>    Hyphens are preferred to underscores in the property names.
> 

Thank you for looking at my patch.

The property is used with underscore in several places, including Generic USB Controller Device Tree Bindings:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/usb/usb.yaml?h=v5.15-rc1#n33

I preferred to used the same pattern and not add a slightly different property string for the same thing.

>> +   "utmi", or "hsic".
>> +
>>  usb1: ehci@...000 {
>>       compatible = "atmel,at91sam9g45-ehci", "usb-ehci";
>>       reg = <0x00800000 0x100000>;
> 
> MBR, Sergei
> 

Kind regards,
Cristian