linux-kernel - Re: [PATCH v2 0/8] fs/ntfs3: Refactor header includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Sep 2021 19:52:46 +0300
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Kari Argillander <kari.argillander@...il.com>,
        <ntfs3@...ts.linux.dev>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/8] fs/ntfs3: Refactor header includes



On 02.09.2021 19:15, Kari Argillander wrote:
> Right now header includes are big mess with ntfs3 imo. We cannot example
> include ntfs3 headers without need of punch of includes to source file.
> This patch set try to address that. When this patch series is applied we
> can include any header file without need of include anything else. This
> does not mean source file should rely what header file includes. Instead
> it should include them by self also if it needs them.
> 
> When some include is added I have write why this is needed to commit
> message. Hopefully this will help when someone wants to correct them
> again. I have also just delete unnecessary headers from some .c files
> and not added what is needed. Usually deleted headers where there
> because ntfs_fs.h need them not file itself. When file was simple enough
> I added all necessary linux headers.
> 
> I did not add linux/headers to all files yet. That is big job. This is
> good starting point. I did try to build every file itself so this will
> build like it should.
> 
> Please do not hesitate to tell if there is something wrong with this
> series or somethings could be done better.
> 
> V2:
> 	Add missing first patch
> 	Rebase
> 	Use base-commit with format-patch
> 
> Kari Argillander (8):
>   fs/ntfs3. Add forward declarations for structs to debug.h
>   fs/ntfs3: Add missing header files to ntfs.h
>   fs/ntfs3: Add missing headers and forward declarations to ntfs_fs.h
>   fs/ntfs3: Add missing header and guards to lib/ headers
>   fs/ntfs3: Change right headers to bitfunc.c
>   fs/ntfs3: Change right headers to upcase.c
>   fs/ntfs3: Change right headers to lznt.c
>   fs/ntfs3: Remove unneeded header files from c files
> 
>  fs/ntfs3/attrib.c                |  5 -----
>  fs/ntfs3/attrlist.c              |  3 ---
>  fs/ntfs3/bitfunc.c               |  7 +------
>  fs/ntfs3/bitmap.c                |  3 ---
>  fs/ntfs3/debug.h                 |  3 +++
>  fs/ntfs3/dir.c                   |  3 ---
>  fs/ntfs3/file.c                  |  1 -
>  fs/ntfs3/frecord.c               |  3 ---
>  fs/ntfs3/fslog.c                 |  4 ----
>  fs/ntfs3/fsntfs.c                |  1 -
>  fs/ntfs3/index.c                 |  1 -
>  fs/ntfs3/inode.c                 |  2 --
>  fs/ntfs3/lib/decompress_common.h |  5 +++++
>  fs/ntfs3/lib/lib.h               |  6 ++++++
>  fs/ntfs3/lznt.c                  | 10 +++++-----
>  fs/ntfs3/namei.c                 |  4 ----
>  fs/ntfs3/ntfs.h                  |  9 +++++++++
>  fs/ntfs3/ntfs_fs.h               | 31 +++++++++++++++++++++++++++++++
>  fs/ntfs3/record.c                |  3 ---
>  fs/ntfs3/run.c                   |  2 --
>  fs/ntfs3/super.c                 |  2 --
>  fs/ntfs3/upcase.c                |  8 ++------
>  fs/ntfs3/xattr.c                 |  3 ---
>  23 files changed, 62 insertions(+), 57 deletions(-)
> 
> 
> base-commit: d3624466b56dd5b1886c1dff500525b544c19c83
> 

Hi Kari!

Thanks for work - applied!