linux-kernel - Re: [PATCH v2 12/15] nfc: trf7970a: drop unneeded debug prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Sep 2021 09:57:57 -0700
From:   Mark Greer <mgreer@...malcreek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Krzysztof Opasiak <k.opasiak@...sung.com>,
        Mark Greer <mgreer@...malcreek.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-nfc@...ts.01.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH v2 12/15] nfc: trf7970a: drop unneeded debug prints

On Mon, Sep 13, 2021 at 03:20:32PM +0200, Krzysztof Kozlowski wrote:
> ftrace is a preferred and standard way to debug entering and exiting
> functions so drop useless debug prints.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
>  drivers/nfc/trf7970a.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
> index 8890fcd59c39..29ca9c328df2 100644
> --- a/drivers/nfc/trf7970a.c
> +++ b/drivers/nfc/trf7970a.c
> @@ -2170,8 +2170,6 @@ static int trf7970a_suspend(struct device *dev)
>  	struct spi_device *spi = to_spi_device(dev);
>  	struct trf7970a *trf = spi_get_drvdata(spi);
>  
> -	dev_dbg(dev, "Suspend\n");
> -
>  	mutex_lock(&trf->lock);
>  
>  	trf7970a_shutdown(trf);
> @@ -2187,8 +2185,6 @@ static int trf7970a_resume(struct device *dev)
>  	struct trf7970a *trf = spi_get_drvdata(spi);
>  	int ret;
>  
> -	dev_dbg(dev, "Resume\n");
> -
>  	mutex_lock(&trf->lock);
>  
>  	ret = trf7970a_startup(trf);
> @@ -2206,8 +2202,6 @@ static int trf7970a_pm_runtime_suspend(struct device *dev)
>  	struct trf7970a *trf = spi_get_drvdata(spi);
>  	int ret;
>  
> -	dev_dbg(dev, "Runtime suspend\n");
> -
>  	mutex_lock(&trf->lock);
>  
>  	ret = trf7970a_power_down(trf);
> @@ -2223,8 +2217,6 @@ static int trf7970a_pm_runtime_resume(struct device *dev)
>  	struct trf7970a *trf = spi_get_drvdata(spi);
>  	int ret;
>  
> -	dev_dbg(dev, "Runtime resume\n");
> -
>  	ret = trf7970a_power_up(trf);
>  	if (!ret)
>  		pm_runtime_mark_last_busy(dev);
> -- 
> 2.30.2

Acked-by: Mark Greer <mgreer@...malcreek.com>