linux-kernel - Re: [PATCH V2] ipc: add set_ownership() and permissions() callbacks for posix mqueue sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c74f33bde7d03d71343cc9251b298ff4@suse.de>
Date:   Mon, 13 Sep 2021 12:42:15 -0700
From:   Davidlohr Bueso <dbueso@...e.de>
To:     Christian Brauner <christian.brauner@...ntu.com>
Cc:     CGEL <cgel.zte@...il.com>, jamorris@...ux.microsoft.com,
        keescook@...omium.org, ktkhai@...tuozzo.com, legion@...nel.org,
        linux-kernel@...r.kernel.org, ran.xiaokai@....com.cn,
        varad.gautam@...e.com
Subject: Re: [PATCH V2] ipc: add set_ownership() and permissions() callbacks
 for posix mqueue sysctl

On 2021-09-13 07:40, Christian Brauner wrote:
> On Fri, Aug 27, 2021 at 03:12:06AM -0700, CGEL wrote:
>> From: Ran Xiaokai <ran.xiaokai@....com.cn>
>> 
>> When a non-root user process creates a user namespace and ipc 
>> namespace
>> with command "unshare -Ur -i", and map the root user inside
>> the user namesapce to the global owner of user namespace.
>> The newly created user namespace OWNS the ipc namespace,
>> So the root user inside the user namespace should have full access
>> rights to the ipc namespace resources and should be writable to
>> the ipc mqueue sysctls.
>> 
>> v2:
>>   - update commit msg.
>>   - fix the coding style issue.
>> Signed-off-by: Ran Xiaokai <ran.xiaokai@....com.cn>
>> ---
> 
> David,
> 
> are you happy with this too? If so I'd pick this up.

LGTM:

Acked-by: Davidlohr Bueso <dbueso@...e.de>