linux-kernel - Re: [PATCH v2 1/2] perf annotate: Fix fused instr logic for assembly functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YT+sOxJeEplSm2pl@kernel.org>
Date:   Mon, 13 Sep 2021 16:53:31 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     "Jin, Yao" <yao.jin@...ux.intel.com>
Cc:     Ravi Bangoria <ravi.bangoria@....com>, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, kim.phillips@....com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] perf annotate: Fix fused instr logic for assembly
 functions

Em Mon, Sep 13, 2021 at 09:54:00AM +0800, Jin, Yao escreveu:
> Hi Arnaldo, Ravi
> 
> On 9/12/2021 3:03 AM, Arnaldo Carvalho de Melo wrote:
> > Em Sat, Sep 11, 2021 at 10:08:53AM +0530, Ravi Bangoria escreveu:
> > > Some x86 microarchitectures fuse a subset of cmp/test/ALU instructions
> > > with branch instructions, and thus perf annotate highlight such valid
> > > pairs as fused.
> > 
> > Jin, are you ok with this? Can I have your reviewed-by?
> > 
> > - Arnaldo
> 
> Oh, my original patch could only handle the case like:
> 
> cmp xxx
> je  aaa
> 
> But it didn't consider Ravi's case something like:
> 
> cmp xxx
> cmp yyy
> je  aaa
> je  bbb
> 
> Thanks for Ravi fixing this issue! Backward searching is probably a better solution.
> 
> Frankly I can't reproduce Ravi's case, but for my test suite, Ravi's patch works as well.
> 
> Reviewed-by: Jin Yao <yao.jin@...ux.intel.com>

Thanks, applied.

- Arnaldo