linux-kernel - Re: [PATCH v2 1/1] tpm/tpm_i2c_infineon: Fix init endian vendor check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169a507329c2273f64c1c7ebab0a3530b19e971e.camel@kernel.org>
Date:   Mon, 13 Sep 2021 23:31:13 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Florian Eckert <fe@....tdt.de>, peterhuewe@....de, jgg@...pe.ca,
        Eckert.Florian@...glemail.com
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] tpm/tpm_i2c_infineon: Fix init endian vendor
 check

On Mon, 2021-09-13 at 14:05 +0200, Florian Eckert wrote:
> On my embedded system I use this tpm infineon chip via i2c bus.
> The system is a MIPS architecture and therefore works in big endian mode.
> 
> The problem is, that the chip type is not correctly recognized,
> because the vendor ID is wrongly aligned in the memory.
> 
> By declaring the vendor ID variable as a `__le32` type, the TPM chip is
> then correctly recognized by the driver and feels then responsible.

Please no hyphens just normal single quotes.

You should have always in a commit message some explanation what
the patch does in imperative form, e.g. "Change type of xxx ...
because ...".

I cannot from find a variable named "vendor ID" from
tpm_tis_i2c_init(). Maybe you are referring to the variable,
of which name is "vendor"?

Finally, the commit message lacks explanation what is changed, i.e.
tpm2_tis_i2c_init() in this case.

Did you find the commit ID where this regression was introduceD?

/Jarkko