[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CA+cxXh=8d=58nJUPstWvO5oEK1fw45s+d5UmKHyAErcSTB2o3A@mail.gmail.com>
Date: Mon, 13 Sep 2021 14:36:42 -0700
From: Philip Chen <philipchen@...omium.org>
To: Stephen Boyd <swboyd@...omium.org>
Cc: Doug Anderson <dianders@...omium.org>,
LKML <linux-kernel@...r.kernel.org>,
Andrzej Hajda <a.hajda@...sung.com>,
Daniel Vetter <daniel@...ll.ch>,
David Airlie <airlied@...ux.ie>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Jonas Karlman <jonas@...boo.se>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Neil Armstrong <narmstrong@...libre.com>,
Robert Foss <robert.foss@...aro.org>,
dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/bridge: parade-ps8640: Use regmap APIs
On Thu, Sep 9, 2021 at 2:27 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> Quoting Doug Anderson (2021-09-09 14:14:29)
> > On Thu, Sep 9, 2021 at 12:09 PM Stephen Boyd <swboyd@...omium.org> wrote:
> > >
> > >
> > > Oh does this have register pages? regmap has support for pages where you
> > > write some indirection register and then access the same i2c address for
> > > the next page. This looks different though and has a different i2c
> > > address for each page?
> >
> > I haven't looked in tons of detail, but I think the right solution
> > here is a separate regmap config per page.
>
> Yes. And then a different .max_register value for each config struct. A
> different .name might be useful to indicate which page it is too.
I see.
I posted v2 with the fix for this.
PTAL.
Powered by blists - more mailing lists