linux-kernel - Re: [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Sep 2021 10:39:34 +0200
From:   Christian König <christian.koenig@....com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>,
        Alex Deucher <alexander.deucher@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is
 due to hardware

Am 13.09.21 um 10:34 schrieb Paul Menzel:
> The warning
>
>      amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported
>
> leaves the reader wondering, if anything can be done about it. As it’s
> unsupported in the hardware, and nothing can be done about, mention that
> in the log message.
>
>      amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported by hardware

I think we should just completely remove the message instead.

Christian.

>
> Signed-off-by: Paul Menzel <pmenzel@...gen.mpg.de>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index c7797eac83c3..c4c56c57b0c0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -599,7 +599,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
>   	default:
>   		adev->gmc.tmz_enabled = false;
>   		dev_warn(adev->dev,
> -			 "Trusted Memory Zone (TMZ) feature not supported\n");
> +			 "Trusted Memory Zone (TMZ) feature not supported by hardware\n");
>   		break;
>   	}
>   }