linux-kernel - Re: [PATCH] mm/memory_hotplug: Add static qualifier for online_policy_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Sep 2021 10:39:50 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Tang Yizhou <tangyizhou@...wei.com>
Cc:     osalvador@...e.de, mhocko@...nel.org, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/memory_hotplug: Add static qualifier for
 online_policy_to_str

On 13.09.21 04:45, Tang Yizhou wrote:
> online_policy_to_str is only used in memory_hotplug.c and should be
> defined as static.
> 
> Signed-off-by: Tang Yizhou <tangyizhou@...wei.com>
> ---
>   mm/memory_hotplug.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 0488eed3327c..4ea91c3ff768 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -57,7 +57,7 @@ enum {
>   	ONLINE_POLICY_AUTO_MOVABLE,
>   };
>   
> -const char *online_policy_to_str[] = {
> +static const char * const online_policy_to_str[] = {
>   	[ONLINE_POLICY_CONTIG_ZONES] = "contig-zones",
>   	[ONLINE_POLICY_AUTO_MOVABLE] = "auto-movable",
>   };
> 

Indeed, thanks

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb