linux-kernel - Re: [PATCH linux-next] tee/optee/shm_pool: fix application of sizeof to pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Sep 2021 11:21:43 +0200
From:   Jens Wiklander <jens.wiklander@...aro.org>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     CGEL <cgel.zte@...il.com>, Sumit Garg <sumit.garg@...aro.org>,
        op-tee@...ts.trustedfirmware.org, linux-kernel@...r.kernel.org,
        jing yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] tee/optee/shm_pool: fix application of sizeof
 to pointer

On Thu, Sep 02, 2021 at 11:34:28AM +0100, Daniel Thompson wrote:
> On Thu, Aug 19, 2021 at 08:21:27PM -0700, CGEL wrote:
> > From: jing yangyang <jing.yangyang@....com.cn>
> > 
> > sizeof when applied to a pointer typed expression gives the size of
> > the pointer.
> > 
> > ./drivers/tee/optee/shm_pool.c:38:28-34: ERROR application of sizeof to pointer
> > 
> > This issue was detected with the help of Coccinelle.
> > 
> > Reported-by: Zeal Robot <zealci@....com.cn>
> > Signed-off-by: jing yangyang <jing.yangyang@....com.cn>
> 
> This should not affect code generation since both pages and *pages are
> pointers but the change looks good to me.
> 
> Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>

Thanks for reviewing, I agree with your analysis. 
I'm picking this up as a bugfix for V5.15.

Cheers,
Jens