linux-kernel - Re: [PATCH] trace: Do some cleanups for osnoise tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Sep 2021 18:05:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Tang Yizhou <tangyizhou@...wei.com>, bristot@...hat.com,
        rostedt@...dmis.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, tangyizhou@...wei.com
Subject: Re: [PATCH] trace: Do some cleanups for osnoise tracer

Hi Tang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[also build test ERROR on v5.15-rc1 next-20210913]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tang-Yizhou/trace-Do-some-cleanups-for-osnoise-tracer/20210913-111459
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 4034fb207e302cc0b1f304084d379640c1fb1436
config: i386-randconfig-r005-20210912 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/cecf38d3b5e23a411856f6c8f3e3be903e439876
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tang-Yizhou/trace-Do-some-cleanups-for-osnoise-tracer/20210913-111459
        git checkout cecf38d3b5e23a411856f6c8f3e3be903e439876
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> kernel/trace/trace_osnoise.c:1826:9: error: initializing 'u64 *' (aka 'unsigned long long *') with an expression of type 'const u64 *' (aka 'const unsigned long long *') discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           .max    = &timerlat_max_period,
                     ^~~~~~~~~~~~~~~~~~~~
   kernel/trace/trace_osnoise.c:1827:9: error: initializing 'u64 *' (aka 'unsigned long long *') with an expression of type 'const u64 *' (aka 'const unsigned long long *') discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           .min    = &timerlat_min_period,
                     ^~~~~~~~~~~~~~~~~~~~
   2 errors generated.


vim +1826 kernel/trace/trace_osnoise.c

a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22  1817  
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22  1818  /*
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22  1819   * osnoise/timerlat_period: min 100 us, max 1 s
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22  1820   */
cecf38d3b5e23a Tang Yizhou                2021-09-13  1821  static const u64 timerlat_min_period = 100;
cecf38d3b5e23a Tang Yizhou                2021-09-13  1822  static const u64 timerlat_max_period = 1000000;
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22  1823  static struct trace_min_max_param timerlat_period = {
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22  1824  	.lock	= &interface_lock,
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22  1825  	.val	= &osnoise_data.timerlat_period,
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22 @1826  	.max	= &timerlat_max_period,
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22  1827  	.min	= &timerlat_min_period,
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22  1828  };
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22  1829  #endif
a955d7eac1779b Daniel Bristot de Oliveira 2021-06-22  1830  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (40580 bytes)