linux-kernel - Re: [PATCH] bnx2x: Fix enabling network interfaces without VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210913104154.GT11834@localhost>
Date:   Mon, 13 Sep 2021 13:41:54 +0300
From:   Adrian Bunk <bunk@...nel.org>
To:     Shai Malin <smalin@...vell.com>
Cc:     Ariel Elior <aelior@...vell.com>,
        Sudarsana Reddy Kalluru <skalluru@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bnx2x: Fix enabling network interfaces without VFs

On Mon, Sep 13, 2021 at 08:14:33AM +0000, Shai Malin wrote:
> On 9/12/2021 at 10:08PM, Adrian Bunk Wrote:
> > This function is called to enable SR-IOV when available,
> > not enabling interfaces without VFs was a regression.
> > 
> > Fixes: 65161c35554f ("bnx2x: Fix missing error code in bnx2x_iov_init_one()")
> > Signed-off-by: Adrian Bunk <bunk@...nel.org>
> > Reported-by: YunQiang Su <wzssyqa@...il.com>
> > Tested-by: YunQiang Su <wzssyqa@...il.com>
> > Cc: stable@...r.kernel.org
> > ---
> >  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > index f255fd0b16db..6fbf735fca31 100644
> > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> > @@ -1224,7 +1224,7 @@ int bnx2x_iov_init_one(struct bnx2x *bp, int
> > int_mode_param,
> > 
> >  	/* SR-IOV capability was enabled but there are no VFs*/
> >  	if (iov->total == 0) {
> > -		err = -EINVAL;
> > +		err = 0;
> >  		goto failed;
> >  	}
> 
> Thanks for reporting this issue!
> But the complete fix should also not use "goto failed".
> Instead, please create a new "goto skip_vfs" so it will skip 
> the log of "Failed err=".

Is this really desirable?
It is a debug print not enabled by default,
and trying to enable SR-IOV did fail.

cu
Adrian