linux-kernel - Re: NAK: [PATCH][next] media: pvrusb2: add newline between two statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b4c86dd-a7d5-ce0d-3ba6-03eba28c0288@canonical.com>
Date:   Mon, 13 Sep 2021 12:04:05 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Hans Verkuil <hverkuil@...all.nl>, Mike Isely <isely@...ox.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: NAK: [PATCH][next] media: pvrusb2: add newline between two
 statements

On 13/09/2021 12:00, Hans Verkuil wrote:
> On 03/09/2021 00:02, Colin Ian King wrote:
>> On 02/09/2021 23:01, Colin King wrote:
>>> From: Colin Ian King <colin.king@...onical.com>
>>>
>>> There are two statements on the same line, add a newline to clean
>>> this up.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>>> ---
>>>  drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>>> index d38dee1792e4..ca00b7fe1e7f 100644
>>> --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>>> +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>>> @@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag)
>>>  				   enable_flag ? "enable" : "disable");
>>>  		}
>>>  		pvr2_hdw_state_sched(hdw);
>>> -	} while (0); LOCK_GIVE(hdw->big_lock);
>>> +	} while (0);
>>> +	LOCK_GIVE(hdw->big_lock);
>>>  	if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret;
>>>  	if (enable_flag) {
>>>  		while ((st = hdw->master_state) != PVR2_STATE_RUN) {
>>>
>>
>> ignore, V2 being sent in a moment.
> 
> I haven't seen a V2 yet... In any case, I've rejected this patch in patchwork.

After looking at all the unconventional code style issues I chose not to
clean this up.

> 
> Regards,
> 
> 	Hans
>