linux-kernel - Re: [PATCH] arm64/kernel: remove duplicate include in process.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210913120908.GA9450@C02TD0UTHF1T.local>
Date:   Mon, 13 Sep 2021 13:09:08 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     cgel.zte@...il.com
Cc:     catalin.marinas@....com, will@...nel.org, pcc@...gle.com,
        maz@...nel.org, peterz@...radead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Lv Ruyi <lv.ruyi@....com.cn>, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] arm64/kernel: remove duplicate include in process.c

On Wed, Sep 01, 2021 at 06:11:26PM -0700, cgel.zte@...il.com wrote:
> From: Lv Ruyi <lv.ruyi@....com.cn>
> 
> Remove all but the first include of linux/sched.h from process.c
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>
> ---
>  arch/arm64/kernel/process.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
> index 19100fe8f7e4..1a1213cca173 100644
> --- a/arch/arm64/kernel/process.c
> +++ b/arch/arm64/kernel/process.c
> @@ -18,7 +18,6 @@
>  #include <linux/mman.h>
>  #include <linux/mm.h>
>  #include <linux/nospec.h>
> -#include <linux/sched.h>
>  #include <linux/stddef.h>
>  #include <linux/sysctl.h>
>  #include <linux/unistd.h>

For the benefit of other reviewers, while it's not obvious from the
patch context, arlier in the includes (which aren't currently sorted),
there's a block with:

| #include <linux/sched.h>
| #include <linux/sched/debug.h>
| #include <linux/sched/task.h>
| #include <linux/sched/task_stack.h>

... and so this patch looks good to me:

Acked-by: Mark Rutland <mark.rutland@....com>

IMO it would be nice to sort the includes if that's not too churny (but
that should be a separate patch).

Thanks,
Mark.