linux-kernel - Re: [PATCH 02/13] kernfs: remove kernfs_create_file and kernfs_create_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210913132043.76lqlamlnyekjp3t@wittgenstein>
Date:   Mon, 13 Sep 2021 15:20:43 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>,
        linux-block@...r.kernel.org, linux-xfs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/13] kernfs: remove kernfs_create_file and
 kernfs_create_file_ns

On Mon, Sep 13, 2021 at 07:41:10AM +0200, Christoph Hellwig wrote:
> All callers actually use __kernfs_create_file.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---

Acked-by: Christian Brauner <christian.brauner@...ntu.com>

>  include/linux/kernfs.h | 24 ------------------------
>  1 file changed, 24 deletions(-)
> 
> diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
> index 1093abf7c28cc..cecfeedb7361d 100644
> --- a/include/linux/kernfs.h
> +++ b/include/linux/kernfs.h
> @@ -568,30 +568,6 @@ kernfs_create_dir(struct kernfs_node *parent, const char *name, umode_t mode,
>  				    priv, NULL);
>  }
>  
> -static inline struct kernfs_node *
> -kernfs_create_file_ns(struct kernfs_node *parent, const char *name,
> -		      umode_t mode, kuid_t uid, kgid_t gid,
> -		      loff_t size, const struct kernfs_ops *ops,
> -		      void *priv, const void *ns)
> -{
> -	struct lock_class_key *key = NULL;
> -
> -#ifdef CONFIG_DEBUG_LOCK_ALLOC
> -	key = (struct lock_class_key *)&ops->lockdep_key;
> -#endif
> -	return __kernfs_create_file(parent, name, mode, uid, gid,
> -				    size, ops, priv, ns, key);
> -}
> -
> -static inline struct kernfs_node *
> -kernfs_create_file(struct kernfs_node *parent, const char *name, umode_t mode,
> -		   loff_t size, const struct kernfs_ops *ops, void *priv)
> -{
> -	return kernfs_create_file_ns(parent, name, mode,
> -				     GLOBAL_ROOT_UID, GLOBAL_ROOT_GID,
> -				     size, ops, priv, NULL);
> -}
> -
>  static inline int kernfs_remove_by_name(struct kernfs_node *parent,
>  					const char *name)
>  {
> -- 
> 2.30.2
>