linux-kernel - Re: [PATCH v2 16/29] ABI: sysfs-bus-soundwire-slave: use wildcards on What definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89985d2d-2aff-b7d6-ad9f-535655a5feb5@linux.intel.com>
Date:   Tue, 14 Sep 2021 10:28:21 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>
Cc:     Jonathan Corbet <corbet@....net>, Vinod Koul <vkoul@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 16/29] ABI: sysfs-bus-soundwire-slave: use wildcards on
 What definitions



On 9/14/21 9:32 AM, Mauro Carvalho Chehab wrote:
> An "N" upper letter is not a wildcard, nor can easily be identified
> by script, specially since the USB sysfs define things like.
> bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl
> to convert it into a Regex.

No objection on the convention but shouldn't that convention be applied
to all attributes?

> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
>  Documentation/ABI/testing/sysfs-bus-soundwire-slave | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-soundwire-slave b/Documentation/ABI/testing/sysfs-bus-soundwire-slave
> index d324aa0b678f..db6b8ffa753e 100644
> --- a/Documentation/ABI/testing/sysfs-bus-soundwire-slave
> +++ b/Documentation/ABI/testing/sysfs-bus-soundwire-slave
> @@ -64,7 +64,7 @@ Description:	SoundWire Slave Data Port-0 DisCo properties.
>  		Data port 0 are used by the bus to configure the Data Port 0.
>  
>  
> -What:		/sys/bus/soundwire/devices/sdw:.../dpN_src/max_word
> +What:		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_word
>  		/sys/bus/soundwire/devices/sdw:.../dpN_src/min_word
>  		/sys/bus/soundwire/devices/sdw:.../dpN_src/words
>  		/sys/bus/soundwire/devices/sdw:.../dpN_src/type

if we change max_word, shouldn't we change all the others as well?