linux-kernel - Re: [PATCH 0/2] Implement XDP in r8169

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7b36b2ac-223f-a34a-4f86-7f4f0b027898@gmail.com>
Date:   Tue, 14 Sep 2021 18:22:55 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Guilin Tang <tangguilin@...ontech.com>, nic_swsd@...ltek.com,
        davem@...emloft.net, kuba@...nel.org
Cc:     ast@...nel.org, linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH 0/2] Implement XDP in r8169

On 14.09.2021 11:31, Guilin Tang wrote:
> I implemented XDP on the r8169 driver so that people in need can use it.
> 
> Guilin Tang (2):
>   r8169:Add XDP support for pass and drop actions
>   r8169: ADD XDP support for redirect action
> 
>  drivers/net/ethernet/realtek/r8169_main.c | 161 ++++++++++++++++++++--
>  1 file changed, 151 insertions(+), 10 deletions(-)
> 

I don't know XDP, therefore my review comments don't cover the
functionality. As prerequisite for merging this series somebody
knowing XDP would have to review the functional part.

Some comments would be helpful on which platforms and with which 
chip versions you tested.

Last but not least: I can't support the XDP extension. Therefore I'd ask you
to provide the needed support (incl. monitoring bugzilla.kernel.org) in case
of any problem reports, even if not directly related to XDP.
The XDP changes may brake other stuff.